GH-141: Add timeout for compilation; cancel/interrupt tasks on timeout and close#142
Merged
andreaTP merged 3 commits intoroastedroot:mainfrom Mar 4, 2026
Merged
GH-141: Add timeout for compilation; cancel/interrupt tasks on timeout and close#142andreaTP merged 3 commits intoroastedroot:mainfrom
andreaTP merged 3 commits intoroastedroot:mainfrom
Conversation
…s on timeout and shutdown
andreaTP
approved these changes
Mar 4, 2026
Collaborator
andreaTP
left a comment
andreaTP
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot!
Do we have an easy way to test the thread-leak and use-after free?
Contributor
Author
I've added a commit that tries to test the 'thread leak' (really it just code continuing to execute); the use after free I'm not sure how to test |
andreaTP
approved these changes
Mar 4, 2026
Collaborator
andreaTP
left a comment
andreaTP
left a comment
There was a problem hiding this comment.
Looks good, thanks @q-nathangrand !
Contributor
Author
|
Awesome, thanks for the speedy turn around your side! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.