demoapp listening address more wider, required to dockerized solution. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lhost. Added dockerized solution to demoapp.
|
Thank you for the PR. This demo repo should be simple as possible and I agree that in most cases docker is good solution, in this repo it might leave people to wrong path. Therefore I am thinking that we should leave the docker out of this repository. But we can change the: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demoapp listening address chanced to more wider: localhost => 0.0.0.0
In docker container call come over ip so localhost not work.
Added dockerized solution of demoapp that benefit is that it goes backround automaticly.