Add AddressableLEDBuffer - #254
Merged
Merged
Conversation
Probably not a great idea, we could probably manually bind std::span<LEDData> instead...
auscompgeek
force-pushed
the
led-buffer
branch
3 times, most recently
from
May 16, 2026 13:22
74f80ec to
b441672
Compare
auscompgeek
marked this pull request as ready for review
May 16, 2026 14:30
Member
Author
|
@codex review |
virtuald
reviewed
May 17, 2026
I think I was hoping implicit conversions would be picked up by pybind11. Unfortunately that doesn't seem to be the case.
auscompgeek
commented
May 20, 2026
Member
|
LGTM |
virtuald
approved these changes
Jun 6, 2026
PeterJohnson
pushed a commit
to wpilibsuite/allwpilib
that referenced
this pull request
Jun 22, 2026
I tasked Claude with converting the existing C++ tests to python for wpilib. I gave it a decent review for comparison to the existing tests, and it seems to have covered everything. I did do some small cleanup in a couple of places. One notable test that is missing is the LED patterns, but that is getting handled in [mostrobotpy](robotpy/mostrobotpy#254) land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253