Skip to content

Conversation

@ikelax
Copy link
Contributor

@ikelax ikelax commented Jun 13, 2025

This PR is related to #6301. I started to add test cases for listAppend.

Is this actually what the issue addresses? This is my first contribution and I am very new to Zig.

The PR is still a WIP because I first want to make sure that I am heading in the right direction.

@lukewilliamboswell
Copy link
Collaborator

Hey @ikelax thanks for checking. I think this is on track and the kind of unit tests @bhansconnect was talking about. Also, feel free to drop a post in Zulip contributing channel if you have anything to discuss, it is likely to get more eyeballs over there. I'm also happy to help review anything you have when you're ready.

I would suggest you make any changes in src/builtins for the new zig compiler and not in crates/compiler/builtins/bitcode/src.

There are two versions of the zig builtins in the compiler (running on different versions of zig), and this is the old rust implementation, which isn't being actively developed any longer. We are keeping it here so the current rust compiler builds and we can fix any high priority issues should they arise.

ikelax added 2 commits June 15, 2025 23:07
The list.zig file under crates is for the old compiler.

See also: roc-lang#7827 (comment)
@github-actions
Copy link

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants