feat: add login api #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliakseitokarev
force-pushed
the
feat/add-login-api
branch
from
cfe1b31 to
952b8aa
Compare
Shastel
requested changes
Aug 19, 2025
| TRANSFER_TOKEN_SALT=tobemodified | ||
| JWT_SECRET=tobemodified | ||
| ENCRYPTION_KEY=tobemodified | ||
| NEXT_SERVER_API_TOKEN=ebab379d647f6afd984a390254830a120f5592a6052337abac544b2239a774e17a24144f04e09b8986e39bf34523b1bf4cc639003de6f551f07a088abfaf617dd62195f0cc95e04909ea714d62848b93aeb94daa555613e2e13084a11e71c21453d7cadecdb1a7a7fd50400762fc2c479277d2bfcfde36dbaac6fb18f38342bf |
| } | ||
| try { | ||
| const user: BaseUser & {created: boolean} = await loginService.loginUser({ githubId, email }); | ||
| return ctx.send(user, user.created ? 201 : 200); |
There was a problem hiding this comment.
it will be more readable if you first calculate the status code, and then just pass it to send it like
const statusCode = user.created ? CREATED : OK;
return ctx.send(user, statusCode);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom policy next-server-api-token.
Add user login endpoint with token
Without token
Without token
