feat: add login page #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi.ts for reusable API helpers; add /dashboard as a protected route with logout
Shastel
requested changes
Sep 16, 2025
| } | ||
|
|
||
| const params = new URLSearchParams({ | ||
| client_id: process.env.NEXT_PUBLIC_GITHUB_CLIENT_ID!, |
There was a problem hiding this comment.
It would be better to check env variables before forming the request, and send a 500 if env variables are missing
| }); | ||
|
|
||
| const response = await fetch( | ||
| "https://github.com/login/oauth/access_token", |
There was a problem hiding this comment.
it also would be a common practice to have this url in the env varibale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.