[tutorials] Remove vetos that are not needed anymore #19595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
tutorial_veto
branch
from
9a1b214 to
b2eb47a
Compare
Test Results 20 files 20 suites 2d 21h 55m 28s ⏱️ Results for commit 3cefffd. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
tutorial_veto
branch
from
b2eb47a to
7bdcb97
Compare
* Disabling `exampleFit3D.C` tutorial for `NOT clad` is not needed anymore because root-project#15091 was fixed. * The `df107_SingleTopAnalysis.py` and `df103_NanoAODHiggsAnalysis.*` should now work on macOS too * Disabling the `machine_learning/keras` tutorials was misleading because it suggested that these tutorials only fail on macOS, while they actually fail on on all platforms with TensorFlow>=2.16, which is why `tmva-pymva` was globally disabled in the CI and in the builds.
guitargeek
force-pushed
the
tutorial_veto
branch
from
7bdcb97 to
3cefffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling
exampleFit3D.Ctutorial forNOT cladis not needed anymore because Clad is an optional module but TFormula (and tests of) fails without it. #15091 was fixed.The
df107_SingleTopAnalysis.pyanddf103_NanoAODHiggsAnalysis.*should now work on macOS tooDisabling the
machine_learning/kerastutorials was misleading because it suggested that these tutorials only fail on macOS, while they actually fail on on all platforms with TensorFlow>=2.16, which is whytmva-pymvawas globally disabled in the CI and in the builds.