[tmva][sofie] Optimize ROperator_Tile with a direct-mapping algorithm #19603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjibansg
requested changes
Aug 19, 2025
|
|
||
| const int rank = fShapeInput.size(); | ||
|
|
||
| out << SP << "const int input_shape[" << rank << "] = " << ConvertShapeToString(fShapeInput) << ";\n"; |
There was a problem hiding this comment.
maybe better to use size_t here instead of just int.
cc: @lmoneta
|
|
||
| // For each output element, calculating the corresponding input element's index. | ||
| out << SP << SP << "for (int i = 0; i < " << rank << "; ++i) {\n"; | ||
| out << SP << SP << SP << "const int out_coord = current_idx / output_strides[i];\n"; |
There was a problem hiding this comment.
could we avoid these repetitive division steps since they are more expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
This PR improves the performance of the ROperator_Tile by replacing its code generation logic.
The previous implementation used an iterative method with multiple loops and std::copy operations.
The new implementation uses a faster direct-mapping algorithm. It pre-calculates memory strides and then uses a single loop to compute the source index for each destination element.
Checklist: