[core] prevent integer overflow when calling Align

[ferdymercury]

This Pull request:

Changes or fixes:

Fixes a alloc-size-larger in TString::Recommend (cap+1) compiler warning often seen in the CI of the PRs. Since Align sums 16 and leads to overflow if close to kMaxInt.

Check warning on line 1294 in core/base/src/TString.cxx
GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

argument 1 value ‘18446744071562067968’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]

Check warning on line 1294 in core/base/src/TString.cxx
GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

argument 1 value ‘18446744071562067968’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]

You can reproduce the bug by running:

TString s; s.Append('a', kMaxInt-15);
(bad-alloc)
TString s; s.Append('a', kMaxInt-16);
works fine.

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #

[github-actions]

Test Results

    20 files      20 suites   3d 7h 11m 7s ⏱️
 3 257 tests  3 257 ✅ 0 💤 0 ❌
63 493 runs  63 493 ✅ 0 💤 0 ❌

Results for commit ed52211.

♻️ This comment has been updated with latest results.

[pcanal]

Thanks.