Skip to content

[nfc] consistent renaming of all buffersize variables #19610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2025

Conversation

ferdymercury
Copy link
Collaborator

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Philippe Canal <[email protected]>
Copy link

github-actions bot commented Aug 11, 2025

Test Results

    21 files      21 suites   3d 8h 19m 44s ⏱️
 3 257 tests  3 257 ✅ 0 💤 0 ❌
66 672 runs  66 672 ✅ 0 💤 0 ❌

Results for commit cd3298f.

♻️ This comment has been updated with latest results.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing failures are unexpected and seem to be triggered by this PR.

@ferdymercury ferdymercury requested a review from pcanal August 12, 2025 06:35
@ferdymercury
Copy link
Collaborator Author

The testing failures are unexpected and seem to be triggered by this PR.

there was one typo. Seems fixed now.

@dpiparo dpiparo self-assigned this Aug 12, 2025
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM (need squash when merging)

@pcanal pcanal merged commit a21a966 into root-project:master Aug 13, 2025
41 of 48 checks passed
@ferdymercury ferdymercury deleted the buffrename branch August 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants