-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[nfc] consistent renaming of all buffersize variables #19610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d76e686
to
e5522a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Philippe Canal <[email protected]>
Test Results 21 files 21 suites 3d 8h 19m 44s ⏱️ Results for commit cd3298f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing failures are unexpected and seem to be triggered by this PR.
there was one typo. Seems fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM (need squash when merging)
See #19606 (comment)