Skip to content

HS3 Bugfix and changes #19617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

HS3 Bugfix and changes #19617

merged 3 commits into from
Aug 13, 2025

Conversation

Phmonski
Copy link
Contributor

@Phmonski Phmonski commented Aug 12, 2025

This Pull request:

HS3 changes - Bug fix with integral names and including RooPolyVar and RooChebychev classes

Changes:

Include RooPolyVar into RooPolynomial templates
Include RooChebychev into generic pdf streamer
Integration name character replacements

Fixed version of PR #19616

Copy link

Test Results

    21 files      21 suites   3d 5h 46m 32s ⏱️
 3 363 tests  3 352 ✅ 0 💤 11 ❌
68 846 runs  68 835 ✅ 0 💤 11 ❌

For more details on these failures, see this check.

Results for commit 584fc85.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes, thanks!

@guitargeek
Copy link
Contributor

One note for the future: if you messed up a PR branch, you can also make sure that your new fixed branch locally has the name name as the old PR branch and do a git force push with git push -f. The PR will automatically update and things will be correct again.

@guitargeek guitargeek merged commit 06e79bf into root-project:master Aug 13, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants