[math][genvector] Implement pair acoplanarity and asymmetry functions #19618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
changed the title
Test Results 20 files 20 suites 3d 2h 50m 16s ⏱️ For more details on these failures, see this check. Results for commit 09e7441. ♻️ This comment has been updated with latest results. |
hageboeck
added a commit
to hageboeck/root
that referenced
this pull request
Aug 13, 2025
With free functions being added to for the GenVector package in root-project#19618, it will be a problem to find these functions in the ROOT documentation. This is because of a name clash between the GenVector namespace vs the GenVector group. Doxygen links to the former, whereas the latter has all the documentation. Since the namespace was only wrapping the Throw function, GenVector::Throw can be replaced by GenVector_Throw, and the namespace can be removed. This should make the doxygen documentation more useful.
hageboeck
reviewed
Aug 13, 2025
There was a problem hiding this comment.
Hello @ferdymercury,
I have a few suggestions, could you have look?
as suggested by Stephan Co-authored-by: Stephan Hageboeck <[email protected]>
as suggested by Stephan Co-authored-by: Stephan Hageboeck <[email protected]>
hageboeck
approved these changes
Aug 14, 2025
hageboeck
added a commit
that referenced
this pull request
Aug 14, 2025
With free functions being added to for the GenVector package in #19618, it will be a problem to find these functions in the ROOT documentation. This is because of a name clash between the GenVector namespace vs the GenVector group. Doxygen links to the former, whereas the latter has all the documentation. Since the namespace was only wrapping the Throw function, GenVector::Throw can be replaced by GenVector_Throw, and the namespace can be removed. This should make the doxygen documentation more useful.
|
It would have been good to squash this PR so individual commits in the repository history always compile, simplifying bisection... |
|
Sorry about that. The only workaround I can suggest at this point is to create a file in the repo called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #19338
Fyi @Rik002
Checklist: