Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ jobs:
is_special: true
property: march_native
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "builtin_zlib=ON", "builtin_zstd=ON"]
- image: alma9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the experiment use for arm64? i.e. shouldn't we still test both alma9 and alma10.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I would prefer to not blow up the CI matrix too much for no reason. If you want, we can also keep Alma 9. In the end, the motivation for this PR was to demo that aarch64 works with gcc 14, which is shipped with Alma 10. If I can show that, #14446 can be closed.

In any case, if the fixes to h2root and the RVec tests successfully fix the problems with Alma 10 ARM, I will open independent PRs for these fixes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpiparo What coverage do we need for arm64/alma?

- image: alma10
is_special: true
property: arm64
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "builtin_zlib=ON", "builtin_zstd=ON"]
Expand Down
Loading