[VecOps] Remove outdated IsSmall helper function in tests
#20534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
approved these changes
Nov 26, 2025
Contributor
Author
|
While this is certainly a good change, it didn't fix the GCC 14 ARM 64 failures unfortunately. So I have to push again, updating the commit message |
The commit 2605710 changed from using the `ROOT::Detail::VecOps::` namespace explicitly for `IsSmall` to a `using` statement. However, there was also a remnant `IsSmall` function with an outdated implementation in the test file itself, which we can now remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit guitargeek@2605710 changed from using the
ROOT::Detail::VecOps::namespace explicitly forIsSmallto ausingstatement. However, there was also a remnantIsSmallfunction with an outdated implementation in the test file itself, which we can now remove.