Support interactive TBrowser in python #20550
Open
+138
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as with TCanvas::Draw(), provide block flag to let run event loop until user press space key
Let use it for pythonization of TCanvas and TBrowser
Test Results 22 files 22 suites 3d 17h 20m 32s ⏱️ For more details on these failures, see this check. Results for commit a2d4536. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Nov 27, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks! Some minor comments from my side
|
|
||
| # \endcond | ||
|
|
||
| def run_root_event_loop(): |
Member
There was a problem hiding this comment.
Suggested change
| def run_root_event_loop(): | |
| def _run_root_event_loop(): |
I think this function is not "public API", so we can signal it in the naming convention
| will be suspended until <space> key pressed by user. Simple example: | ||
| \code{.py} | ||
| \endcode |
Member
There was a problem hiding this comment.
I think this \endcode should be placed at the end of the Python snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following approach from #17587
Implement alternative TBrowser::Draw() which runs event loop when block option is on.
So one can use TBrowser (web and classic) from any python session just doing:
Or one can directly provide block parameter to the constructor:
Move
run_root_event_loopfunction to__init__.pyscript - while it used from canvas and from browser