-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/login form managament #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new login form feature with form state management and validation, restructuring the authentication flow to follow a cleaner modular architecture. The changes introduce reusable UI components, form validators, and reorganize the file structure to separate authentication pages from main application pages.
- Adds comprehensive form validation for email and password fields with user-friendly error messages
- Introduces a reusable
PrimaryButtoncomponent with loading and disabled states - Restructures page organization:
/pages/auth/for authentication and/pages/main/for main app screens
Reviewed Changes
Copilot reviewed 17 out of 24 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
modules/domain/lib/services/auth_service.dart |
Reformatted logInWithCredentials method parameters for better readability |
modules/domain/lib/bloc/auth/auth_cubit.dart |
Changed login method to use named parameters and renamed username to email |
modules/common/lib/validators/form_validator.dart |
Added new validator class with email and strong password validation methods |
modules/common/lib/core/resource.dart |
Added message getter to RError class for easier error message access |
app/pubspec.yaml |
Added gap package dependency for spacing widgets |
app/lib/presentation/ui/pages/main/home/home_view.dart |
Created new home view with logout functionality |
app/lib/presentation/ui/pages/main/home/home_page.dart |
Updated import path to reflect new directory structure |
app/lib/presentation/ui/pages/auth/login/login_page.dart |
Implemented new login page with centered card layout |
app/lib/presentation/ui/pages/auth/login/login_form.dart |
Created comprehensive login form with validation, terms agreement, and error handling |
app/lib/presentation/ui/components/primary_button.dart |
Added reusable primary button component with loading and disabled states |
app/lib/presentation/themes/spacing.dart |
Removed old Spacing class (replaced by Dimen constants) |
app/lib/presentation/themes/local_theme.dart |
Enhanced disabled button styling and added card theme configuration |
app/lib/presentation/resources/resources.dart |
Removed Spacing extensions (migrated to Dimen constants) |
app/lib/presentation/resources/locale/intl_*.arb |
Added localization strings for login form labels, errors, and instructions |
app/lib/presentation/resources/locale/generated/*.dart |
Auto-generated localization code from new ARB entries |
app/lib/presentation/resources/dim.dart |
Added spacing and dimension constants to replace old Spacing class |
app/lib/presentation/navigation/routers.dart |
Updated import paths to reflect new directory structure |
app/lib/presentation/ui/pages/auth/sign_up/* |
Created placeholder sign-up page files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
098fc84 to
0d86fb4
Compare
tarruk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Preview