-
Notifications
You must be signed in to change notification settings - Fork 130
Setup New Relic dashboards and alerts with terraform #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,3 @@ | |||
NEW_RELIC_ACCOUNT_ID=1234 | |||
NEW_RELIC_API_KEY=NRAK-** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this ok? in the config/newrelic.yml
you are changing NEW_RELIC_API_KEY
for NEW_RELIC_LICENSE_KEY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the config change is actually not related with our TF setup, it's a fix for the new_relic config. It requires both, licence and API keys.
@@ -0,0 +1,524 @@ | |||
{ | |||
"name": "Activerecord - ${app_name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Activerecord - ${app_name}", | |
"name": "ActiveRecord - ${app_name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could merge it as it is and we can fix/tune it as we start using it 👌
ty for this work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! My only concern is that there's no remote state for Terraform. All resources will be tracked using local state (created by the person who runs the terraform commands and saved locally). This means that if anyone else wants to update the NewRelic resources, Terraform won't know that there are already resources created and will create new ones.
You can configure remote state using an S3 bucket and a DynamoDB table, it's not a big deal and it's a huge win. If this is something you think it's worth it, let me know and we can discuss further.
This PR adds: