Apply provides feedback #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 vulnerabilities (1 low, 17 moderate, 24 high, 2 critical) fixed. 3 moderate vulnerabilities remain.
Currently the apply command line feature is broken because we are programmatically navigating to a mailto link which is blocked in current browsers (see: https://stackoverflow.com/questions/71583658/not-allowed-to-launch-cutom-protocol-because-a-user-gesture-is-required.) I first try to rewrite the `term.stylePrint` with a new mailto: regex in addition to the http regex. My next approach was to write a new `term.displayMailto` function. Both of these failed because of the poor support for mailto in current browsers. This is a temporary fix so that users know that apply isn't broken. In the future if you'd make a form endpoint available to me I'd love to write an interactive application prompt where they could answer a few questions right there and have the mail send via our backend.
Currently the apply command line feature is broken because we are programmatically navigating to a mailto link which is blocked in current browsers (see: https://stackoverflow.com/questions/71583658/not-allowed-to-launch-cutom-protocol-because-a-user-gesture-is-required.) I first try to rewrite the `term.stylePrint` with a new mailto: regex in addition to the http regex. My next approach was to write a new `term.displayMailto` function. Both of these failed because of the poor support for mailto in current browsers. This is a temporary fix so that users know that apply isn't broken. In the future if you'd make a form endpoint available to me I'd love to write an interactive application prompt where they could answer a few questions right there and have the mail send via our backend.
…wski/cli-website into apply-provides-feedback
Breaking our CLI, will address in future commit.
|
Our netlify-cli dependency is very outdated, introducing 47 vulnerabilities (1 low, 21 moderate, 23 high, 2 critical.) I'd love to update this and push but our CI is expecting certain versions and breaks when updating that dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the apply command line feature is broken because we are programmatically navigating to a mailto link which is blocked in current browsers (see: https://stackoverflow.com/questions/71583658/not-allowed-to-launch-cutom-protocol-because-a-user-gesture-is-required.)
I first try to rewrite the
term.stylePrintwith a new mailto: regex in addition to the http regex. My next approach was to write a newterm.displayMailtofunction.Both of these failed because of the poor support for mailto in current browsers.
This is a temporary fix so that users know that apply isn't broken.
In the future if you'd make a form endpoint available to me I'd love to write an interactive application prompt where they could answer a few questions right there and have the mail send via our backend.