Skip to content
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
35a2323
feat(rqt): Add update rate and async info to details window
ShahazadAbdulla Sep 2, 2025
b61236d
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Sep 3, 2025
bda5c2c
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Sep 3, 2025
086847b
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Sep 4, 2025
ee2dcc5
Merge branch 'master' into feature/2166-rqt-from-scratch
christophfroehlich Sep 8, 2025
3bbfcb6
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Oct 26, 2025
6767824
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
ea2396f
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
920c5ce
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
2dab9dc
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
9770303
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
508aaeb
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
c23bca6
Update rqt_controller_manager/rqt_controller_manager/controller_manag…
ShahazadAbdulla Oct 26, 2025
6c4e154
feat(rqt): Reset labels to fix stale data display
ShahazadAbdulla Oct 26, 2025
9c885c2
feat(rqt): Address review feedback and apply formatting
ShahazadAbdulla Oct 26, 2025
62dbf33
Merge branch 'master' into feature/2166-rqt-from-scratch
christophfroehlich Oct 28, 2025
b46df68
Merge branch 'ros-controls:master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Nov 3, 2025
53e4a07
fix(rqt): Reset info dialog labels to prevent stale data
ShahazadAbdulla Nov 3, 2025
3993876
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Nov 3, 2025
b656edf
Merge branch 'master' into feature/2166-rqt-from-scratch
ShahazadAbdulla Nov 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions rqt_controller_manager/resource/popup_info.ui
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,46 @@
<enum>Qt::PlainText</enum>
</property>
</widget>
</item>
<item row="2" column="0">
<widget class="QLabel" name="label_update_rate">
<property name="text">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-weight:600;&quot;&gt;Update Rate:&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="textFormat">
<enum>Qt::RichText</enum>
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="QLabel" name="label_update_rate_value">
<property name="text">
<string>N/A</string>
</property>
<property name="textFormat">
<enum>Qt::PlainText</enum>
</property>
</widget>
</item>
<item row="3" column="0">
<widget class="QLabel" name="label_async_setting">
<property name="text">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-weight:600;&quot;&gt;Async Setting:&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="textFormat">
<enum>Qt::RichText</enum>
</property>
</widget>
</item>
<item row="3" column="1">
<widget class="QLabel" name="label_async_setting_value">
<property name="text">
<string>N/A</string>
</property>
<property name="textFormat">
<enum>Qt::PlainText</enum>
</property>
</widget>
</item>
</layout>
</item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,44 @@ def _on_ctrl_info(self, index):
popup.ctrl_name.setText(ctrl.name)
popup.ctrl_type.setText(ctrl.type)

update_rate = "N/A"
is_async = "N/A"

try:
# Check for per-controller params first
param_names = [f"{ctrl.name}.update_rate", f"{ctrl.name}.is_async"]
response = call_get_parameters(
node=self._node, node_name=self._cm_name, parameter_names=param_names
)

# Check the response for valid types
# INTEGER is type 2, BOOL is type 1, NOT_SET is 0
if response.values[0].type == 2: # Found per-controller update_rate
update_rate = f"{response.values[0].integer_value} Hz"
if response.values[1].type == 1: # Found per-controller is_async
is_async = str(response.values[1].bool_value)

# If per-controller update_rate not found, check global
if update_rate == "N/A":
response_global = call_get_parameters(
node=self._node, node_name=self._cm_name, parameter_names=["update_rate"]
)
# Check for a valid response and correct type (INTEGER = 2)
if response_global.values and response_global.values[0].type == 2:
update_rate = f"{response_global.values[0].integer_value} Hz (Global)"

# Set a default for is_async if not found
if is_async == "N/A":
is_async = "False (Default)"

except Exception as e:
self._node.get_logger().warning(
f"Could not get some parameters for controller {ctrl.name}: {e}"
)

popup.label_update_rate_value.setText(update_rate)
popup.label_async_setting_value.setText(is_async)

res_model = QStandardItemModel()
model_root = QStandardItem("Claimed Interfaces")
res_model.appendRow(model_root)
Expand Down