Skip to content

Conversation

@hoffmann-stefan
Copy link

rebased version of dirk-thomas/vcstool#239

ping @furushchev FYI

We use this this fix for our internal codebase. If this is merged we could switch back to an official release.

should fix dirk-thomas/vcstool#271

@hoffmann-stefan hoffmann-stefan force-pushed the fix-validate-git-hash branch from f177981 to b0e027b Compare July 21, 2025 06:42
@claraberendsen
Copy link
Contributor

Thanks @hoffmann-stefan for rebasing the PR. We are looking at cutting a release with was was there and small updates to get CI working first and soon after another one with the long pending community contributions with this PR reviewed in that cycle.
Just wanted to give you a heads up on the reason for the delay.

Copy link
Collaborator

@leander-dsouza leander-dsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @hoffmann-stefan for the fix :)

@leander-dsouza leander-dsouza merged commit 961b177 into ros-infrastructure:main Aug 20, 2025
11 checks passed
@claraberendsen
Copy link
Contributor

@hoffmann-stefan I would like to ask if you can delete the fork you have of this repo now that this is merged. We want to break away from the upstream fork network and having child forks prevents us to do it easily. Any further contribution is always welcomed and once this repo becomes the root of a new fork network.

Additionally this change is already available on 1.1.3 version of vcs2l released last week: https://pypi.org/project/vcs2l/1.1.3.

@hoffmann-stefan
Copy link
Author

@claraberendsen I did delete my fork.

Thanks for the review, merge and release of this fix, we will look forward to use your fork in our tooling :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate fails with commit hash

4 participants