Skip to content

Conversation

@leander-dsouza
Copy link
Collaborator

@leander-dsouza leander-dsouza commented Aug 19, 2025

Note

#27 needs to be merged prior to the review of this PR.

Basic Info

Info Please fill out this column
Ticket(s) this addresses #198 #265
Primary OS tested on Ubuntu
Is this a breaking change? No
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • This is a direct port of #265.

  • There are two commands in vcs that have the ability to retry - validate and import.
    Both of these functions run ls-remote; however, only validate has the self.run_command() function enabled with the retry flag.

    This is missing from the import command as seen here.

Description of how this change was tested

  • Run the export command at the root of the repository on the main branch:

    vcs export . > repos.yaml
    repositories:
      vcs2l:
        type: git
        url: [email protected]:ros-infrastructure/vcs2l.git
        version: leander-dsouza/enable-import-retry
  • Next, disable your local connection, and run the import command to view the retry logs:

    mkdir temp && cd temp
    vcs import --input ../repos.yaml .
    
    Retrying command (1/2): /usr/bin/git ls-remote [email protected]:ros-infrastructure/vcs2l.git leander-dsouza/enable-import-retry
    Retrying command (2/2): /usr/bin/git ls-remote [email protected]:ros-infrastructure/vcs2l.git leander-dsouza/enable-import-retry
    
    === ./vcs2l (git) ===
    Could not determine ref type of version: ssh: Could not resolve hostname github.com: Temporary failure in name    resolution
    fatal: Could not read from remote repository.
    
    Please make sure you have the correct access rights
    and the repository exists.

@leander-dsouza leander-dsouza changed the base branch from main to leander-dsouza/add-ruff August 19, 2025 09:21
@leander-dsouza leander-dsouza marked this pull request as ready for review August 19, 2025 09:22
@leander-dsouza leander-dsouza force-pushed the leander-dsouza/enable-import-retry branch from 9c17935 to bf898e1 Compare August 19, 2025 09:36
Base automatically changed from leander-dsouza/add-ruff to main August 19, 2025 15:35
Signed-off-by: Leander Stephen D'Souza <[email protected]>
@leander-dsouza leander-dsouza force-pushed the leander-dsouza/enable-import-retry branch from bf898e1 to a710f21 Compare August 19, 2025 15:58
Copy link
Contributor

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable and is a good UX improvement!

@leander-dsouza leander-dsouza merged commit 3242959 into main Aug 20, 2025
11 checks passed
@leander-dsouza leander-dsouza deleted the leander-dsouza/enable-import-retry branch August 20, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants