Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2025

Description

Add ContentFilteredTopic interface

Fixes #1504

Is this user-facing behavior change?

No

Did you use Generative AI?

No


This is an automatic backport of pull request #1506 done by Mergify.

Signed-off-by: Barry Xu <[email protected]>
(cherry picked from commit 8d42eaa)

# Conflicts:
#	rclpy/rclpy/impl/_rclpy_pybind11.pyi
#	rclpy/rclpy/node.py
#	rclpy/rclpy/subscription.py
#	rclpy/src/rclpy/subscription.cpp
#	rclpy/src/rclpy/subscription.hpp
#	rclpy/test/test_subscription.py
@mergify
Copy link
Contributor Author

mergify bot commented Oct 10, 2025

Cherry-pick of 8d42eaa has failed:

On branch mergify/bp/jazzy/pr-1506
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 8d42eaa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   rclpy/rclpy/subscription_content_filter_options.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   rclpy/rclpy/impl/_rclpy_pybind11.pyi
	both modified:   rclpy/rclpy/node.py
	both modified:   rclpy/rclpy/subscription.py
	both modified:   rclpy/src/rclpy/subscription.cpp
	both modified:   rclpy/src/rclpy/subscription.hpp
	both modified:   rclpy/test/test_subscription.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Barry-Xu-2018
Copy link
Contributor

I will handle build issue.

@fujitatomoya
Copy link
Collaborator

Pulls: #1521
Gist: https://gist.githubusercontent.com/fujitatomoya/6bdb45a035b6790f2e3a29777b3d09ec/raw/be17410bada7a60ddcc34189ef53e66d0c50142b/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17278

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 can you check https://ci.ros2.org/job/ci_windows/25713/ are unrelated warnings to this PR just in case. (i believe those are not related.)

@Barry-Xu-2018
Copy link
Contributor

@fujitatomoya

can you check https://ci.ros2.org/job/ci_windows/25713/ are unrelated warnings to this PR just in case. (i believe those are not related.)

Yes. The failed tests are unrelated to this PR.
Besides, I try to rerun Windows CI

  • Windows Build Status

@ahcorde ahcorde requested a review from fujitatomoya October 13, 2025 07:18
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Barry-Xu-2018 i am not inclined to take this backport... what do you think?

@@ -0,0 +1,1281 @@
# Copyright 2024 Open Source Robotics Foundation, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole file is added in this PR, but originally this is not the content filtering API enhancement. I am not really comfortable with adding this entire file because of this backport.

  1. probably it would be better to discuss on adding this pybind11 file aside from cft backport.
  2. then we can come back on this PR to backport cft feature.

i think that would be the right procedure to have the consensus with PMC? what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .pyi file is just for stubs/type information for the Python bindings (e.g., for static type checking). I would just delete this file and keep the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants