-
Notifications
You must be signed in to change notification settings - Fork 257
Add content-filtered-topic interfaces (backport #1506) #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jazzy
Are you sure you want to change the base?
Conversation
Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit 8d42eaa) # Conflicts: # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/node.py # rclpy/rclpy/subscription.py # rclpy/src/rclpy/subscription.cpp # rclpy/src/rclpy/subscription.hpp # rclpy/test/test_subscription.py
|
Cherry-pick of 8d42eaa has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
I will handle build issue. |
Signed-off-by: Barry Xu <[email protected]>
|
Pulls: #1521 |
|
@Barry-Xu-2018 can you check https://ci.ros2.org/job/ci_windows/25713/ are unrelated warnings to this PR just in case. (i believe those are not related.) |
Yes. The failed tests are unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barry-Xu-2018 i am not inclined to take this backport... what do you think?
| @@ -0,0 +1,1281 @@ | |||
| # Copyright 2024 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole file is added in this PR, but originally this is not the content filtering API enhancement. I am not really comfortable with adding this entire file because of this backport.
- probably it would be better to discuss on adding this pybind11 file aside from cft backport.
- then we can come back on this PR to backport cft feature.
i think that would be the right procedure to have the consensus with PMC? what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This .pyi file is just for stubs/type information for the Python bindings (e.g., for static type checking). I would just delete this file and keep the rest.
Description
Add ContentFilteredTopic interface
Fixes #1504
Is this user-facing behavior change?
No
Did you use Generative AI?
No
This is an automatic backport of pull request #1506 done by Mergify.