Expose the possibility to create ROS node with custom NodeOptions
#1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncapat
changed the title
NodeOptions
ahcorde
approved these changes
Mar 14, 2025
|
Pulls: #1347
|
roncapat
commented
Mar 14, 2025
rviz_common/include/rviz_common/ros_integration/ros_client_abstraction.hpp
Outdated
Show resolved
Hide resolved
…traction.hpp Signed-off-by: Patrick Roncagliolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams some small changes useful for launching Rviz with custom
NodeOptions.For example, this allows to enable IPC communication and obtain the maximum yield from #1331 and #1346.
In commit 0e4cfda the class
RosNodeAbstractionis enabled.In commit d916ac0 the class
RosClientAbstractionis enabled.In commit 072a01a the
mainfunction gets an explicit hint of the new entrypoint for node option injection.