Skip to content

Conversation

Zyrin
Copy link

@Zyrin Zyrin commented Jul 10, 2025

Description

Replaces the use of gz::math::MassMatrix3d::EquivalentBox in RobotLink::createInertia with an implementation in Eigen similar to what was suggested here: #740 (comment)
This removes the gz_math(_vendor) dependency

This was done because we are building ros2(including rviz2) and gazebo separately and ran into the problem of having two different gz_math(_vendor) libraries/versions.

Is this user-facing behavior change?

No.

Did you use Generative AI?

No.

@jmachowinski
Copy link

@ahcorde How can we test this ?

@Zyrin
Copy link
Author

Zyrin commented Jul 10, 2025

@ahcorde Do you have any idea how I can fix these linter errors? Eigen is a C++ library so I do not understand the error message.

…n implementation that uses Eigen and thus removes the gz_math dependency

Signed-off-by: Alexis Tsogias <[email protected]>
@traversaro
Copy link
Contributor

Just to understand, so we are removing the heavily tested EquivalentBox gz-math function with some untested code. That seems a bit more as a workaround for a specific problem of a build setup, rather then something useful per se (mostly as in the future it could be convenient to use other harder to replace gz-math functionality). Just to understand, why can't you build gazebo and ros using the same gz-math version?

@asymingt asymingt added the more-information-needed Further information is required label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants