Revert "Revert "Replace deprecated spin_until_future_complete"" #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
approved these changes
Jul 19, 2022
Contributor
audrow
force-pushed
the
revert-504-revert-499-hliberacki/spin_until
branch
from
a921110 to
5ea04af
Compare
…in_until_complete (#499)" (#504)" This reverts commit 4318235. Signed-off-by: Audrow Nash <[email protected]>
audrow
force-pushed
the
revert-504-revert-499-hliberacki/spin_until
branch
from
5ea04af to
16a55ae
Compare
Member
Member
|
I've opened #541 to replace this PR. |
Member
|
This can be closed, see #541 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #504
Merge this once related prs are ready.