Skip to content

rename and rework releases.json for easier management#83

Open
johndoh wants to merge 4 commits intoroundcube:masterfrom
johndoh:releases
Open

rename and rework releases.json for easier management#83
johndoh wants to merge 4 commits intoroundcube:masterfrom
johndoh:releases

Conversation

@johndoh
Copy link
Contributor

@johndoh johndoh commented Feb 15, 2026

there is a small visual change in the result but this should be esaier to manage.

Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the initiative and contribution!

I'd like to keep the version in the headlines, see my proposed change.

Besides that I like this and would like to merge it!

{% if params.packages.size == 0 %}
{% continue %}
{% endif %}
<h2 id="{{ id }}">{{ params.title }} <a class="anchor" href="#{{ id }}" aria-label="Link to this section: {{ params.title }}"></a></h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind having the files in the table, but I'd prefer to still have the version in the headlines, too.

Suggested change
<h2 id="{{ id }}">{{ params.title }} <a class="anchor" href="#{{ id }}" aria-label="Link to this section: {{ params.title }}"></a></h2>
<h2 id="{{ id }}">{{ params.title }} {{% if params.packages[0].version %}}- {{ params.packages[0].version }}{{% endif %}}<a class="anchor" href="#{{ id }}" aria-label="Link to this section: {{ params.title }}"></a></h2>

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past there have been multiple versions in LTS so putting the version number in the header of all sections is not always possible but I think I can easily solve that with a flag in the config. That will essentially restore the current format but still be flexible. I'll update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants