Render each mime-part into an individual iframe by pabzm · Pull Request #9787 · roundcube/roundcubemail

pabzm · 2025-02-20T10:22:03Z

Implementing #9465

A new clean restart over the previous pull request.

TODO:

reading emails using mailvelope
check/change larry skin
Don't "wash" HTML content twice
Check reading emails with enigma
Fix hide_blockquote plugin
Find out why the "loading" message gets hidden so early in chromium-based browsers.

alecpl · 2025-03-23T12:04:37Z

program/js/app.js

            fn = function (kr) {
-                ref.mailvelope_keyring = kr;
-                ref.mailvelope_init(action, kr);
+                this.afterAllContentIframesLoaded(() => {


it should be ref not this.

alecpl · 2025-03-23T12:07:37Z

program/js/app.js

+                    // Hide "Loading data" message.
+                    $(iframe).siblings('.loading').hide();
+                    // Show remote objects notice
+                    if (iframe.contentDocument.body.dataset.extlinks === 'true') {


I'mk getting "TypeError: iframe.contentDocument is null" when opening any message.

alecpl · 2025-03-23T13:06:26Z

I gave it a try, here are some more issues:

I see that we do not load our styles.css into the iframes. I.e. drark mode is broken, the plain text messages font is not monospace, signatures aren't greyed, blockquotes unstyled, etc.
messages charset is broken (for messages in charset other than utf-8).
the loading element disappears in onload (?), I think it's too late. I.e. sometimes I see both this element and iframe content being loaded. It does not look good. Maybe solution is to style the iframes in an "overlay" style loader, where that element is on top of the loaded iframe.
performance: the simplest case - opening a plain text message. I get two imap connections both of them do SELECT INBOX, UID FETCH 33469 (UID RFC822.SIZE FLAGS..., UID FETCH 33469 (BODY.PEEK[1]). Even more redundancy when loading a html message with images.
for performance reasons the format-change action (switching between HTML and plain text) should probably be changed to not reload the whole preview frame, but only the #messagebody element. Not a big deal for now.
when Enigma plugin can't decrypt a message the "loading data" message never disappears. I also think this plugin will need some other non-trivial updates.
small margin issue at the bottom of a preview frame, when you have a message with attached image and "Display attached images below the message" enabled.

This includes a new "message loading" notice without meta refresh (which requires unsafe-inline in a CSP, which we want to avoid)

We need the information in the browser, because the remote-objects-message is now rendered independently from the message contents, and we need it for each message part.

The calling code replaced the $rcmail->output on the fly, which makes is hardly testable. Also that class was used only in the class `rcmail_action_mail_get`, and it's a pretty thin layer on top of `rcmail_output_html`, which is not necessary.

pabzm · 2025-04-30T09:21:48Z

Thank you for the review!

The missing styling was an artefact of a rebase after the breaking changes. I fixed that now, but during that I found that displaying text attachments in the new window had additional bugs and differences to the current state of the "master" branch.

While fixing those I stumbled upon something unexpected: text/plain parts are rendered differently from the preview vs. attachment view (new window, _action=get). The former wraps it in a div.pre with styling, the latter wraps it in a pre and applies no styling.

~~@alecpl Can you explain why that is and/or if that needs to be kept? It would be easier to render both cases the same.~~

Update: Scratch that, I get it now.

Note: This breaks tests that download files

pabzm · 2025-07-31T07:33:32Z

FTR: This won't receive any updates in the near future due to a focus shift and resource exhaustion.

pabzm requested a review from alecpl February 20, 2025 10:22

pabzm self-assigned this Feb 20, 2025

pabzm force-pushed the message-render-iframe branch 4 times, most recently from 4fd3901 to 2a397fe Compare February 21, 2025 10:47

pabzm force-pushed the message-render-iframe branch from 2a397fe to 44b0165 Compare March 5, 2025 13:40

pabzm changed the title ~~Message render iframe~~ Render each mime-part into an individual iframe Mar 5, 2025

pabzm force-pushed the message-render-iframe branch 4 times, most recently from 937cb49 to 50fb5bb Compare March 6, 2025 10:49

pabzm marked this pull request as draft March 7, 2025 12:28

pabzm removed this from 💌 📅 👥 Groupware team Mar 19, 2025

pabzm force-pushed the message-render-iframe branch 2 times, most recently from 46353ff to e2038f0 Compare March 21, 2025 14:45

pabzm marked this pull request as ready for review March 21, 2025 15:20

alecpl reviewed Mar 23, 2025

View reviewed changes

pabzm added 10 commits April 24, 2025 15:12

Render each mime part in an individual, sandboxed iframe

1019b46

This includes a new "message loading" notice without meta refresh (which requires unsafe-inline in a CSP, which we want to avoid)

Replace REMOTE_OBJECTS with an attribute on the body element

08dc83b

We need the information in the browser, because the remote-objects-message is now rendered independently from the message contents, and we need it for each message part.

Remove rcmail_html_page

3a9ad6b

The calling code replaced the $rcmail->output on the fly, which makes is hardly testable. Also that class was used only in the class `rcmail_action_mail_get`, and it's a pretty thin layer on top of `rcmail_output_html`, which is not necessary.

Fix plugin 'hide_blockquote' for iframed message parts

5bdbaf5

Wait until iframes have been loaded

ff58dd4

Fix switching light/dark mode for iframed email content

4d79c3b

Fix styling for iframed email content

06314ef

WIP: use .message-(html)part only on iframed html elem

b2345fc

Fix styling for iframed email content parts

65f4397

Use styles.css, not embed.css for iframed html parts

a0076ca

pabzm added 4 commits April 28, 2025 12:52

Fix styles for iframed email content parts

696cfa9

re-fix iframed email content styling

d583ccc

Use ref where necessary

75b451c

WIP styling

a36613c

pabzm added 19 commits April 30, 2025 12:04

Avoid empty script element

78fb78c

Allow to skip delivering jquery-ui script and styles

6eca46d

Fix scrolling long texts in attachment view

b670e65

Fix showing text/* in attachment view

fcf0ccb

fixup: fix showing text/* attachments

f8b07cd

Don't include jquery-ui in iframed message content iframe

cb9fb14

Don't htmlify text/plain parts if displayed as attachment

550d5d3

Two comments

0a6dcf1

Regain lost _mimewarning URL param

dd7a9e1

Allow stylesheets from 'self' in download headers

49c2d44

Move inline styles from attachment view to embed.less

6540f67

WIP: style images in attachment view

2c6c3cb

Allow fallback to embed.min.css

5c10569

Fix browser tests via docker compose

3bcc53f

WIP: PrintToPDF

734225c

docker volumes for NPM and composer packages in testing

824ff6f

WIP: reduce artifacts of testing in source code dir

16f9de1

Note: This breaks tests that download files

New: broad .dockerignore

88569eb

Tests for external window

2803464

pabzm force-pushed the message-render-iframe branch from e2038f0 to 2803464 Compare July 8, 2025 06:05

pabzm marked this pull request as draft July 31, 2025 07:33

pabzm removed their assignment Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render each mime-part into an individual iframe#9787

Render each mime-part into an individual iframe#9787
pabzm wants to merge 33 commits intomasterfrom
message-render-iframe

pabzm commented Feb 20, 2025 •

edited

Loading

Uh oh!

alecpl Mar 23, 2025

Uh oh!

alecpl Mar 23, 2025

Uh oh!

alecpl commented Mar 23, 2025 •

edited

Loading

Uh oh!

pabzm commented Apr 30, 2025 •

edited

Loading

Uh oh!

pabzm commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pabzm commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alecpl Mar 23, 2025

Choose a reason for hiding this comment

Uh oh!

alecpl Mar 23, 2025

Choose a reason for hiding this comment

Uh oh!

alecpl commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pabzm commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pabzm commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pabzm commented Feb 20, 2025 •

edited

Loading

alecpl commented Mar 23, 2025 •

edited

Loading

pabzm commented Apr 30, 2025 •

edited

Loading