Skip to content

Conversation

jimwhite
Copy link

GitHub Copilot's attempt at fixing #387

It fails so obviously not an actual fix. I was so hopeful as it was chugging along but it got stuck on this failure:

FAILED tests/test_nyse_calendar.py::test_christmas_eve_post_market_close - AssertionError: assert Timestamp('2019-12-24 18:00:00+0000', tz='UTC') == Timestamp('2019-12-24 17:00:00-0500', tz='America/New_York')

But I assume it also causes these too:

FAILED tests/test_nyse_calendar.py::test_day_after_thanksgiving - AssertionError: assert Timestamp('2012-11-23 15:00:00-0500', tz='America/New_York') > Timestamp('2012-11-23 22:00:00+0000', tz='UTC')
FAILED tests/test_nyse_calendar_early_years.py::test_1999 - ValueError: cannot reindex on an axis with duplicate labels
FAILED tests/test_utils.py::test_mark_session_edge_case - AssertionError: Series are different

So just sharing in case it is at all helpful. I have to use an ugly hack in my application for now but I'll come back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants