Skip to content

Do not implement existing #values to weakmap #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release61
Choose a base branch
from
Open

Do not implement existing #values to weakmap #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,13 +779,15 @@ module ActiveRecord
if RUBY_ENGINE == "jruby"
require "jruby"

class org.jruby::RubyObjectSpace::WeakMap
field_reader :map
end
unless ObjectSpace::WeakMap.new.respond_to? :values
class org.jruby::RubyObjectSpace::WeakMap
field_reader :map
end

class ObjectSpace::WeakMap
def values
JRuby.ref(self).map.values.reject(&:nil?)
class ObjectSpace::WeakMap
def values
JRuby.ref(self).map.values.reject(&:nil?)
end
end
end
end
end