Drop driven_by(:selenium) #2856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my testing, it does not have any influence.
|
Why does this command fail for you? What if you run this manually? |
|
Apologies for the delay here, as far as I can tell / remember the point of these is to ensure the tests are running on a javascript capable runner, but as the test on line 33 shows, the default is a selenium driver... So I guess my question is why they work when removing the explicit driver selection when the default should also be chromedriver... I'm not adversed to merging this, but if theres a more complex behaviour going on I'd like to understand it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing Ruby on Rails 8.0.2 in Fedora, the rubygem-rspec-rails package test suite started to fail with errors such as:
As it turns out, this due to missing Chromedriver. However, this was not needed previously with Ruby on Rails 7.0 and it seems it is needed due to this change.
Of course one option would be to let the test have the the Chromedriver. But that is big beast. So I tried to remove the
driven_by(:selenium), expecting the something will fail by some way, but nothing happened and the test suite still seems to be happy.I am very likely missing something and doing something wrong and in that case sorry for the noise. But maybe not and this change is worth of it.