Feature: add truncation detection to the Tooltip component - #336
Draft
b1ink0 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional truncation-aware display behavior to Tooltip, supporting the linked next-pms enhancement.
Changes:
- Adds
showWhenandtruncationRefprops. - Detects horizontal text truncation before opening.
- Adds Storybook controls and interaction coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
utils.ts |
Adds truncation detection utility. |
types.ts |
Defines the new public props and mode type. |
tooltip.tsx |
Conditionally cancels tooltip opening. |
tooltip.stories.tsx |
Documents the new props in Storybook. |
tooltip.interactions.stories.tsx |
Tests truncated and non-truncated cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new feature to the
Tooltipcomponent, allowing tooltips to be shown only when the associated text is visually truncated.Relevant Technical Choices
showWhenprop ("always"or"truncated") and an optionaltruncationRefprop toTooltipProps, allowing tooltips to appear only when the referenced element's text is truncated.Testing Instructions
Screenshot/Screencast
Checklist
Partially fixes rtCamp/next-pms#2052