Fix incorrect lloc count when there's a colon in the line (fixes #262)#263
Open
devdanzin wants to merge 1 commit intorubik:masterfrom
Open
Fix incorrect lloc count when there's a colon in the line (fixes #262)#263devdanzin wants to merge 1 commit intorubik:masterfrom
devdanzin wants to merge 1 commit intorubik:masterfrom
Conversation
…nd statement keyword is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
raw._logicalavoid counting lines with colons as two logical lines unless a compound statement keyword is present.There's still an issue, because "match" and "case" are soft keywords, so
_logicalwill still count 2 llocs on a line like:However, this change makes the count right for the common cases and wrong only for questionable (as in "using soft keywords as variable names") code.
Fixes #262.