Skip to content

exporter: Update --frames to accept "all" to export all frames #20930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

exporter: Update --frames to accept "all" to export all frames #20930

wants to merge 5 commits into from

Conversation

AeroXuk
Copy link
Contributor

@AeroXuk AeroXuk commented Jul 5, 2025

Split from #20896

  • Support --frames all to export all frames.

@AeroXuk AeroXuk changed the title Update frames cli command to accept "all" to export all frames. exporter: Update frames cli command to accept "all" to export all frames. Jul 5, 2025
@AeroXuk AeroXuk changed the title exporter: Update frames cli command to accept "all" to export all frames. exporter: Update --frames to accept "all" to export all frames Jul 5, 2025
@AeroXuk AeroXuk mentioned this pull request Jul 5, 2025
Closed
kjarosh
kjarosh reviewed Jul 5, 2025
View reviewed changes
@kjarosh
Copy link
Member

kjarosh commented Jul 5, 2025

Your approach of parsing FrameSelection is the right way to do it!

@AeroXuk @kjarosh
Update exporter/src/main.rs
933ed72 
Co-authored-by: Kamil Jarosz <[email protected]>
@kjarosh kjarosh added exporter Issues related to the exporter tool A-other Area: Not covered by other area labels T-feature Type: New Feature (that Flash doesn't have) labels Jul 7, 2025
@kjarosh
Copy link
Member

kjarosh commented Jul 20, 2025

I'm sorry for stalling your exporter PRs, I've been adding some tests for exporter so that we don't break existing use cases and we can cover future ones (#21029, #21042).

I think the PRs can be rebased now (the main.rs diff should apply to lib.rs now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjarosh kjarosh kjarosh left review comments

Assignees
No one assigned
Labels
A-other Area: Not covered by other area labels exporter Issues related to the exporter tool T-feature Type: New Feature (that Flash doesn't have)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AeroXuk @kjarosh