core: Allow loading fonts into memory lazily #20959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves memory footprint by preventing fonts from being loaded eagerly into memory. Instead, it's possible to pass a file reference to a font, which will be used to load data from the font file when needed. This mechanism is used on desktop. This patch also introduces a preloading mechanism, that makes sure we read from the font file once per a text fragment, and not for each glyph.
kjarosh
added
A-desktop
|
Converted to draft, as I think using mmap will be a better solution |
|
Closing in favor of #20969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves memory footprint by preventing fonts from being loaded eagerly into memory. Instead, it's possible to pass a file reference to a font, which will be used to load data from the font file when needed. This mechanism is used on desktop.
This patch also introduces a preloading mechanism, that makes sure we read from the font file once per a text fragment, and not for each glyph.