-
-
Notifications
You must be signed in to change notification settings - Fork 922
desktop: Prefer non-sRGB surface formats #20965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If you have any ideas/capacity, @Dinnerbone, I'd appreciate you helping out (or even taking over, as you please). |
dcc5195
to
8f1373c
Compare
I am now on the opinion that this hasn't even worked correctly before with both sRGB and linear surface formats - the difference is just less noticeable when the mismatch is one way than when in the other (when it's darkening vs. when it's lightening). |
See, wrt. #21730:
(Please excuse the window shadow in one of the screenshots...) |
So maybe this should be included in #21730 instead of being separate...? |
actually, since this has nothing to do with wgpu 26, we could switch to the egui 0.32.3 release first, and have this fix included for it, (and then later, if we want wgpu 26, switch back to a later egui master, but that's an independent story). |
8f1373c
to
313a781
Compare
313a781
to
5d8a8e3
Compare
Okay, added an |
This is
a half measureto unblock #20898 (following emilk/egui#7311) - the colors are probably still not right if only sRGB formats are supported.