Skip to content

core: Cross Domain security checks using the crossdomain.xml #20986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evilpie
Copy link
Collaborator

@evilpie evilpie commented Jul 12, 2025

No description provided.

@n0samu
Copy link
Member

n0samu commented Jul 13, 2025

I believe CORS on the modern web serves the same purpose that crossdomain.xml served for the Flash plugin, so I'm not sure it makes sense to enforce crossdomain.xml policies by default. Especially because our users have not had to worry about it for all this time, so many of them are probably not using the proper crossdomain.xml policy file anymore, meaning if we suddenly started enforcing it we would break their sites. Additionally, any mistake we make will break resource loading on some people's sites, which is a problem that people often find uniquely difficult to diagnose and debug. And there are a lot of sources of mistakes:

  • Any misunderstanding of how the policies work
  • Any mistake in choosing the default values
  • Any incompleteness in our implementation
  • Any difference in our XML parser, including handling different character encodings

@evilpie
Copy link
Collaborator Author

evilpie commented Jul 13, 2025

This would not be enabled by default.

@n0samu
Copy link
Member

n0samu commented Jul 13, 2025

Okay thanks for clarifying ❤️ carry on!

@danielhjacobs danielhjacobs added A-core Area: Core player, where no other category fits T-compat Type: Compatibility with Flash Player security-sandbox Issues related to Flash Player security sandboxes labels Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core player, where no other category fits security-sandbox Issues related to Flash Player security sandboxes T-compat Type: Compatibility with Flash Player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants