Skip to content

avm2: fix coercion to function error for Vector.some and Array.some #21002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SuchAFuriousDeath
Copy link
Contributor

@SuchAFuriousDeath SuchAFuriousDeath commented Jul 14, 2025

Completes #12321.

Also factored out some code into a separate function for the 1006 and 1034 errors as a bonus.

@SuchAFuriousDeath SuchAFuriousDeath changed the title avm2: improve coercion to function error for Vector.some and Array.some avm2: fix coercion to function error for Vector.some and Array.some Jul 14, 2025
@Molisson
Copy link

This might fix #12321.

@SuchAFuriousDeath
Copy link
Contributor Author

This might fix #12321.

It does, that's the point! :D

@kjarosh kjarosh added A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) labels Jul 17, 2025
@SuchAFuriousDeath SuchAFuriousDeath force-pushed the fix-vector-some-tests branch 2 times, most recently from 321420f to 13cca91 Compare July 18, 2025 18:23
@Lord-McSweeney Lord-McSweeney enabled auto-merge (squash) July 19, 2025 19:35
@Lord-McSweeney Lord-McSweeney merged commit 2ff3690 into ruffle-rs:master Jul 19, 2025
22 of 24 checks passed
@SuchAFuriousDeath SuchAFuriousDeath deleted the fix-vector-some-tests branch July 19, 2025 19:43
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Jul 20, 2025
-----------------------------------------------------------------------------------
cemu.mk c1c2962b6633017cd956c6925288e2529c532ee4 # Version: Commits on Jul 19, 2025
-----------------------------------------------------------------------------------
Switch to a different Discord RPC implementation

discord-rpc has been unmaintained for years,

----------------------------------------------------------------------------------
clk.mk cf20c84edd3b92f57f61024408c1b1efbeecb81f # Version: Commits on Jul 20, 2025
----------------------------------------------------------------------------------
Merge pull request #1523 from TomHarte/MacintoshIMGStyle

Use <algorithm>, and otherwise reduce.,

-------------------------------------------------------------------------------------
hatari.mk 31c147d077307b03aa2e96a40d796063c0a65d4c # Version: Commits on Jul 19, 2025
-------------------------------------------------------------------------------------
Update releases notes,

---------------------------------------------------
pcsx2.mk v2.5.73 # Version: Commits on Jul 19, 2025
---------------------------------------------------
- [GitHub: Add types to issue templates](PCSX2/pcsx2#13042)

------------------------------------------------------------------------------------
rpcs3.mk 7fe3afbbc222aa2ab299833d25b65987c005e178 # Version: Commits on Jul 19, 2025
------------------------------------------------------------------------------------
Add support for arrowlake-s and lunarlake CPUs,

---------------------------------------------------------------
ruffle.mk nightly-2025-07-20 # Version: Commits on Jul 20, 2025
---------------------------------------------------------------
## What's Changed

* exporter: Add integration tests by @kjarosh in ruffle-rs/ruffle#21029

* avm2: handle limit = 0 in String.split by @SuchAFuriousDeath in ruffle-rs/ruffle#21033

* avm2: Match avmplus's array index parsing by @Lord-McSweeney in ruffle-rs/ruffle#21027

* avm2: fix coercion to function error for Vector.some and Array.some by @SuchAFuriousDeath in ruffle-rs/ruffle#21002

* avm2: Hand out stack slices to Activations instead of accessing a global stack by @Lord-McSweeney in ruffle-rs/ruffle#20829

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-07-19...nightly-2025-07-20,

-------------------------------------------------------------------------------------------
xenia-native.mk 5e4a04f38324000cc603ee17b140be2428511b3d # Version: Commits on Jul 18, 2025
-------------------------------------------------------------------------------------------
[CI] Remove Clang 19 build,

-----------------------------------------------------------------------------------
ymir.mk 0e2e70003499dfa195af998433008aec5eebbc9f # Version: Commits on Jul 20, 2025
-----------------------------------------------------------------------------------
feat(system): Map simple arrays directly as pointers into the Bus struct to improve overall performance,

---------------------------------------------------------------------------------------
alephone.mk 502311272040c3f6875f9c395c0997462a0d5354 # Version: Commits on Jul 19, 2025
---------------------------------------------------------------------------------------
Fix steam build with sdk 1.62 (breaking change from 1.61) : RequestUserStats has been removed

from Steamworks sdk source code: this call is no longer required as it is managed by the Steam client

The game stats and achievements will be synchronized with Steam before

the game process begins.,

------------------------------------------------------------------------------------
box64.mk 2d164c89e28fced0a7db3725442bf3a0c8da86af # Version: Commits on Jul 19, 2025
------------------------------------------------------------------------------------
[BUNDLE] Check for broken symlinks (#2829)

to prevent issues such as #2825,

---------------------------------------------------------------------------------------
corsixth.mk b2ce950af466fcf78ce765759e60071d78b96698 # Version: Commits on Jul 19, 2025
---------------------------------------------------------------------------------------
Merge pull request #2941 from rmnvgr/remove-html-entities

Remove unknown HTML entities from metainfo,

----------------------------------------------------------------------------------------
openmohaa.mk 0bd11596073f9ff473d2a9b40380bfcd6da97b1c # Version: Commits on Jul 19, 2025
----------------------------------------------------------------------------------------
Fix notation,

----------------------------------------------------------------------------------
stk.mk 1fba350ea8b6ab2407569677d7a79060233ab0b1 # Version: Commits on Jul 19, 2025
----------------------------------------------------------------------------------
Set default graphics parameters to match preset level 5,

----------------------------------------------------------------------------------------
supertux2.mk 0ddc5266c6f2b27dbf029684ea7587f27726aeea # Version: Commits on Jul 20, 2025
----------------------------------------------------------------------------------------
Update translations,

---------------------------------------------------------------------------------------------------
mupen64plus-gliden64.mk 05706206e2fdb4f275befa7d65956a2e666a050b # Version: Commits on Jun 06, 2025
---------------------------------------------------------------------------------------------------
Fixing the pink text in the worst and most ridiculously honored RPG on the N64... obviously undeserved,

----------------------------------------------------------------------------------------
doomretro.mk 2ac914e451da2c68eab3f5cccb5b8bef863283de # Version: Commits on Jul 20, 2025
----------------------------------------------------------------------------------------
Update releasenotes.md,

-----------------------------------------------------------------------------------
tr1x.mk 5c10a76da09d1fa4e5deafaedba49b4a9f5cd992 # Version: Commits on Jul 19, 2025
-----------------------------------------------------------------------------------
camera/common: update camera on initialise

This restores updating the camera when it is initialised, but holds

back on updating the environment until the second frame to avoid

introducing SFX issues such as at the start of Palace Midas.

Resolves #3537.,

-----------------------------------------------------------------------------------
tr2x.mk 5c10a76da09d1fa4e5deafaedba49b4a9f5cd992 # Version: Commits on Jul 19, 2025
-----------------------------------------------------------------------------------
camera/common: update camera on initialise

This restores updating the camera when it is initialised, but holds

back on updating the environment until the second frame to avoid

introducing SFX issues such as at the start of Palace Midas.

Resolves #3537.,

-----------------------------------------------------------------------------------------------
hlsdk-xash3d-dmc.mk d3e437cb68fdeae79cdfecaf6a3b269cf41f0f85 # Version: Commits on Jul 19, 2025
-----------------------------------------------------------------------------------------------
Merge branch 'master' into dmc,

---------------------------------------------------------------------------------------------------
hlsdk-xash3d-zombiex.mk 8d4a4974bafe1135ded79d9b59279c0c770a38a2 # Version: Commits on Jul 19, 2025
---------------------------------------------------------------------------------------------------
Merge branch 'sohl1.2' into zombie-x,

-----------------------------------------------------------------------------------------------
libretro-geolith.mk b683c2f712a6647c69326961a90cf1990e25ccea # Version: Commits on Jul 20, 2025
-----------------------------------------------------------------------------------------------
libretro: Update version string,

------------------------------------------------------------------------------------------------
libretro-nestopia.mk 23d396d642a164d9771923c2e9835515beb9097d # Version: Commits on Jul 20, 2025
------------------------------------------------------------------------------------------------
NstDatabase: Add entry for Ninja JaJaMaru - The Ninja Skill Book,

----------------------------------------------------------------------------------------------
libretro-p2000t.mk 6481f8350ed87da8db3a8bf48c3d21798ae12d75 # Version: Commits on Jul 19, 2025
----------------------------------------------------------------------------------------------
Update build.yml,

--------------------------------------------------------------------------------------------
libretro-puae.mk 3fc66ee4b562910a17e2e2f3bad74572a8bcc134 # Version: Commits on Jul 19, 2025
--------------------------------------------------------------------------------------------
Make WHDLoad ButtonWait optional,

------------------------------------------------------------------------------------------------
libretro-puae2021.mk 03263df64130ce98dc2d712638aae2a3d6722ae2 # Version: Commits on Jul 19, 2025
------------------------------------------------------------------------------------------------
Make WHDLoad ButtonWait optional,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 8c3d0f0984aacee3f006cd5bb6a9b8edf82a6b25 # Version: Commits on Jul 19, 2025
---------------------------------------------------------------------------------------------
build: fix regression in Mac builder

Fix the Mac builder, broken by 3d4c03d0 (build: fix Mac M1 build on my

Mini, 2025-07-19). Remove `-lintl -liconv` from `LDFLAGS` because they

are not available before they are built.

Signed-off-by: Rafael Kitover <[email protected]>,

--------------------------------------------------------------------------------------------
libretro-vice.mk d545628dfacc90c4124381f254c693ec92f6cb7e # Version: Commits on Jul 19, 2025
--------------------------------------------------------------------------------------------
Stop trying to avoid dupe SET_GEOMETRY calls,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants