core/avm1/avm2: Minor fixes to DO lookup, naming, and construction #22170
+229
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
moulins
reviewed
Nov 8, 2025
moulins
reviewed
Nov 8, 2025
Lord-McSweeney
force-pushed
the
core-name
branch
from
3c00a67 to
9774a8b
Compare
moulins
approved these changes
Nov 9, 2025
Lord-McSweeney
force-pushed
the
core-name
branch
from
9774a8b to
5272169
Compare
Lord-McSweeney
removed
the
waiting-on-review
Previously, only access to Graphic was prevented
The name being set is observable from AVM2
`Bitmap` has some abnormal place/construct behavior in FP that we don't correctly reproduce, so it's not included in this test
Lord-McSweeney
force-pushed
the
core-name
branch
from
5272169 to
b041874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MovieClipproperties, we should be enumerating allDisplayObjects with a name, not just interactiveDisplayObjectsDisplayObjectvariants need to get their default instance name set in AVM2Bitmap,Graphic,MorphShape, andTextin AVM1, not justGraphicStaticTextshould be constructed atconstruct_frametime, notpost_instantiationtimeThis includes one test for AVM1 and one test for AVM2.
This progresses
from_gnash/misc-ming.all/DefineTextTest