Conversation
mariaKt
approved these changes
Jan 28, 2026
Collaborator
mariaKt
left a comment
mariaKt
left a comment
There was a problem hiding this comment.
Looks good to me.
Since the gas checks will be part of KEVM, the gas cost in the tests here is unused and not important, but I wanted to point out that all these tests include a gas cost of 3450 (the value before Osaka).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a new hook for P256VERIFY precompile, as specified in EIP-7951, which performs ECDSA signature verification over the secp256r1 curve.
Add a new test harness to run the entire test-vectors.json test suite for the new hook.