Skip to content

Conversation

vadrer
Copy link

@vadrer vadrer commented Oct 27, 2018

...also, it would be reasonable to remove such chunks of code at all:

    if (index($link, "Win32CORE") < 0) {
        my $archdir = $ENV{PERL_CORE} ? "../.." : "$Config{archlib}/..";
        my $win32core = "-L$archdir/lib/auto/Win32CORE -lWin32CORE";
        if (-e "$archdir/lib/auto/Win32CORE/Win32CORE.lib") {
            $win32core = "$archdir/lib/auto/Win32CORE/Win32CORE.lib";
        }
        $link .= " $win32core";
    }

reason for existance of such a code is that by default Win32CORE compiled statically into perl executable, However this current workaround is not robust and not equally good across different version of perl.

rather, correct linkage should be coded.

I will prepare such an edit, if you agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants