Skip to content

avoid using std where we need no_std support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

avoid using std where we need no_std support #46

wants to merge 1 commit into from

Conversation

zoedberg
Copy link
Contributor

No description provided.

@dr-orlovsky
Copy link
Member

We can't do that since error in core became stable only in rust 1.81.0, while our MSRV here is 1.66.0. This won't work

rust-lang/rust#103765 (comment)

@zoedberg
Copy link
Contributor Author

I think we can change MSRV to 1.81.0, in this phase of RGB I don't see the need to support old Rust versions.

@dr-orlovsky
Copy link
Member

dr-orlovsky commented Sep 18, 2024 •
edited
Loading

I think we can change MSRV to 1.81.0, in this phase of RGB I don't see the need to support old Rust versions.

No, this is not a critical security issue and v0.11.0 is already feature-frozen.

MSRV bump across all ecosystem is extremely intrusive and will not be made before the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoedberg @dr-orlovsky