-
Notifications
You must be signed in to change notification settings - Fork 13.6k
llvm: Accept new LLVM lifetime format #145120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Please do not merge this immediately, we're still testing it through the LLVM integration CI. @rustbot label +LLVM-main |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You should also adjust the intrinsic emission in rust/compiler/rustc_codegen_llvm/src/builder.rs Lines 1679 to 1691 in de3efa7
|
LLVM changed the way lifetime intrinsics work in llvm/llvm-project#150248. rust-lang/rust#145120 claims to fix these tests against ToT LLVM, but let's just suppress these until that goes in. Bug: 437926231 Change-Id: I4737655cdd2e4b3f00844a0b89f83c4ec11cf023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6838098 Commit-Queue: Arthur Eubanks <[email protected]> Auto-Submit: Arthur Eubanks <[email protected]> Reviewed-by: Devon Loehr <[email protected]> Commit-Queue: Devon Loehr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1499682}
LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
r? nikic We've got a green run on the HEAD integration: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/39115#01989b27-10da-4bb5-a8e2-d2a4e8dff36c |
@bors r+ |
In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.