style: apply/fix more clippy lints (from cargo::nursery) #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
clippy-tightening
branch
2 times, most recently
from
9b911ae to
cff70a4
Compare
uefi-raw/src/lib.rs
Outdated
| @@ -14,6 +14,8 @@ | |||
| #![cfg_attr(docsrs, feature(doc_auto_cfg))] | |||
| #
There was a problem hiding this comment.
Per https://doc.rust-lang.org/clippy/, nursery lints are "new lints that are still under development". I don't think we should enable these, since there will likely be false positives. If a lint's development is completed then it will naturally graduate to a different group.
There was a problem hiding this comment.
Yeah, fine :)
Background: I use it in all my personal projects and never experienced any drawbacks; but we also do not really need it. So yeah, I'll remove that part from the PR.
Nevertheless, it is beneficial to temporarily activate the corresponding lints locally and see what code can be improved - I found quite some nice improvements
phip1611
force-pushed
the
clippy-tightening
branch
2 times, most recently
from
bdfb4d5 to
5a48c1c
Compare
phip1611
changed the title
phip1611
force-pushed
the
clippy-tightening
branch
from
5a48c1c to
1aebf67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
clippy::nursery, I was able to perform the following improvements:Steps to Undraft
Checklist