Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Oct 30, 2025

  • Added a CHANGELOG.md entry

Since Clone support was removed for chacha20 (RustCrypto/stream-ciphers#462) we must remove Clone for StdRng.

For ReseedingRng, we could:

  1. Make no changes. Effectively it would still lose Clone support with ChaCha*Core.
  2. Add a restriction Rsdr: RngCore (i.e. that the reseeder is infallible) to allow seeding a new inner RNG on clone.
  3. Try to reseed on clone, panic on failure. (I dislike this option.)
  4. Remove Clone support entirely.

I opted for (4) since I suspect this feature has very little usage anyway. If users request that Clone support be restored we can re-evaluate based on the reported use-case and implement it in a patch release.

@dhardy dhardy requested a review from newpavlov October 30, 2025 10:18
@dhardy dhardy merged commit 5fce5ec into master Oct 30, 2025
15 checks passed
@dhardy dhardy deleted the push-xtrmvonsppmw branch October 30, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants