safer bundling/transpiling #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/bundle-fixes
branch
from
ebfe1c6 to
22e0a05
Compare
This was referenced Mar 26, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10 that avoids pulling in node-buffer (which I've tried very hard to avoid) and shouldn't trigger
processorbufferdetection for bundlers by attempting to access them onglobal. So now we have slightly safer browser & Node feature detection and no need for polyfills that seems to fix for Webpack 5 in certain configurations.Also deals with the
**andBigIntproblem and avoids bigint literals which have some compatibility problems for slightly older environments.Also adds
"main"into the distributed package ..@achingbrain I'm going to publish this and 🤞