Skip to content

(BLOCKED) Prompt for SLA agreements - #977

Draft
chrisbendel wants to merge 9 commits into
mainfrom
SHRMP-305
Draft

(BLOCKED) Prompt for SLA agreements#977
chrisbendel wants to merge 9 commits into
mainfrom
SHRMP-305

Conversation

@chrisbendel

Copy link
Copy Markdown
Contributor

No description provided.

@chrisbendel chrisbendel changed the title First pass for SLA user facing modal Prompt for SLA agerements Aug 18, 2026
@chrisbendel chrisbendel changed the title Prompt for SLA agerements Prompt for SLA agreements Aug 18, 2026
@nathanstitt

Copy link
Copy Markdown
Member

hey I took a small peek at this and noticed that the actions are gated inline instead of using a middleware, could probably use that to consolidate the logic.

also was a bit confused by naming, it seems like the same concept, a study-scoped legal agreement is going by three names: SLA, "Study Level Agreement", and "Study Agreement". If these are indeed the same, would be great to consolidate on one.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Total coverage

Lines Branches Functions Statements
96.68% (+0.04%) 77.65% (+0.18%) 93.40% (+0.06%) 96.00% (+0.06%)

Detailed report

3 files with a coverage regression
File Lines Branches Functions Statements
src/app/[orgSlug]/study/[studyId]/review/post-feedback-view.tsx 100.00% 90.62% (+0.62%) 100.00% 98.14% (+0.03%)
src/app/[orgSlug]/study/[studyId]/review/submitted-code-interactive.tsx 100.00% (+0.72%) 97.46% (+1.26%) 92.00% 98.66% (+0.66%)
src/app/[orgSlug]/study/[studyId]/submitted/proposal-submitted.tsx 97.72% (+0.05%) 82.60% 100.00% 95.74% (+0.09%)
src/app/admin/safeinsights/legal/study-agreement/study-agreements.test.tsx 100.00% (+100.00%) 70.00% (+70.00%) 100.00% (+100.00%) 97.45% (+97.45%)
src/app/admin/safeinsights/legal/study-agreement/study-agreements.tsx 100.00% (+100.00%) 85.71% (+85.71%) 100.00% (+100.00%) 100.00% (+100.00%)
src/app/admin/safeinsights/legal/study-agreement/upload-study-agreement-form.tsx 89.58% (+89.58%) 78.94% (+78.94%) 45.00% (+45.00%) 88.46% (+88.46%)
src/components/editable-text/collaborative-editor.tsx 91.93% (+4.03%) 75.00% (+9.62%) 79.31% (+6.90%) 89.78% (+5.84%)
src/components/legal/acknowledgement-modal.tsx 100.00% 100.00% 100.00% (+25.00%) 100.00%
src/components/legal/blocking-modal.tsx 100.00% (+100.00%) 100.00% (+100.00%) 0.00% 100.00% (+100.00%)
src/components/legal/require-study-agreement.test.tsx 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
src/components/legal/require-study-agreement.tsx 100.00% (+100.00%) 69.23% (+69.23%) 90.00% (+90.00%) 100.00% (+100.00%)
src/components/legal/study-agreement-modal.test.tsx 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
src/components/legal/study-agreement-modal.tsx 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
src/components/legal/study-agreement-preparing-notice.tsx 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
🚫 src/lib/realtime/yjs-websocket-context.test.tsx 100.00% 100.00% 95.50% (-1.12%) 100.00%
src/server/actions/legal-document-study-agreement-admin.actions.test.ts 100.00% (+100.00%) 100.00% (+100.00%) 88.88% (+88.88%) 100.00% (+100.00%)
src/server/actions/legal-document-study-agreement-gate.actions.test.ts 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
src/server/actions/legal-document.actions.ts 99.21% (+0.09%) 87.09% (+1.21%) 97.95% (+0.18%) 98.52% (+0.18%)
src/server/actions/study-job.actions.ts 83.84% (+0.12%) 81.39% 76.92% (+0.61%) 82.35% (+0.13%)
src/server/actions/study-request.ts 96.90% (+0.02%) 78.30% 92.59% (+0.29%) 95.27% (+0.02%)
src/server/actions/study.actions.ts 94.83% (+0.02%) 80.24% 100.00% 94.93% (+0.03%)
🚫 src/server/events.ts 90.80% (-0.96%) 88.88% 81.48% (-3.13%) 90.90% (-0.96%)
🚫 src/server/mailer.ts 92.42% (-2.40%) 65.38% (+1.75%) 100.00% 84.72% (-1.21%)
src/server/study-agreement.ts 100.00% (+100.00%) 87.50% (+87.50%) 100.00% (+100.00%) 94.11% (+94.11%)

@chrisbendel chrisbendel changed the title Prompt for SLA agreements (BLOCKED) Prompt for SLA agreements Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants