-
Notifications
You must be signed in to change notification settings - Fork 225
next/store: "course" purchases #8437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7b9c62
to
67550fe
Compare
…resets, add idle timeout help and hide period selection in form
a51bde1
to
1995b38
Compare
…uish where to route back
1995b38
to
e730f95
Compare
932f7b7
to
4a9164f
Compare
4a9164f
to
022163d
Compare
…se -- this should be done in a different way, though, very tricky
7e1e4dc
to
bf046b1
Compare
williamstein
added a commit
that referenced
this pull request
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Course" section to the store, to simplify purchasing a license for a course with a given number of students. It also adds a
HelpIcon
tooltip help for idle timeout – and makes that component work for next.js.The main problems I faced in this PR is how URL vs. form values are handled. I don't know why this is so tricky. Probably something is off how the form is used. In any case, I added explicit default parameters in the initialization, such that everything is in the range of allowed combinations. This is important, because components in the form trigger additional processing of the URL. That's why there is now a flag for the actual initialization and also a flag for parsing the URL.
What I tested is tweaking the form and menu navigating. Then of course, saving the configuration to the cart. Then editing the license, having more than one license in the cart, etc. ... Purchase just works as before, the only new identifying field is
source
. No surprise, because after all, this is still the same type of license.Also, as discussed, this is also recorded in the "info" field of the license, i.e.
store index page
course page
idle timeout help popup
this is also on other pages
consistency check: "course/standard" vs. "site license / standard"
academic, whole of august, 61 students