Skip to content

add 'bz2' and 'dba' module support #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

sschne
Copy link

@sschne sschne commented May 21, 2019

Add support for bzip2 and dba modules

@n-rodriguez
Copy link
Contributor

Looks good to me 👍

@myii myii force-pushed the bz2-dba-support branch from 9bbe595 to 5e04187 Compare June 29, 2019 18:41
@myii myii merged commit 2b479f4 into saltstack-formulas:master Jun 29, 2019
@myii
Copy link
Contributor

myii commented Jun 29, 2019

@pather87 @scambra @n-rodriguez This has been merged, taking the best of #175 as well.

A little explanation for the modifications made to this branch before merging:

  • First up, I tested the merge of both PRs to see what could be salvaged from both.
  • @pather87 I didn't touch your commit's changes but I did rebase against the latest upstream and modify the commit message to work with semantic-release.
  • @scambra Once comparing and removing the currently incomplete xmlrpc functionality, I found that your README changes were very useful, so squashed them into one commit and appended to this PR.
  • @pather87 Since I rebased and merged, you may just find it easier to pull upstream and continue from there -- this branch has fulfilled its purpose.

Finally, thanks to you all your important contributions!

@saltstack-formulas-travis

🎉 This PR is included in version 0.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants