-
Notifications
You must be signed in to change notification settings - Fork 230
fix: warn formula users ng states will be promoted in v1.0.0
#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
myii
merged 6 commits into
saltstack-formulas:master
from
sticky-note:fix/non-ng-deprecation
Aug 1, 2019
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d033381
fix: warn formula users ng states will be promoted in `v1.0.0`
e97eeae
fix: change message to warn about upcoming deprecation
myii 8e7471e
fix: allow muting deprecation warning via. pillar/config entry
myii d45bae8
fix: add warning message for ng states
1a5d734
fix(pillar_from_files): use `{}` pillar files to ensure tests pass
myii 3ac59e4
fix(readme): add warning in docs/README.rst
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-adodb: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-apc: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-apcu: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-bcmath: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-cgi: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-cli: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-curl: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# -*- coding: utf-8 -*- | ||
# vim: ft=sls | ||
|
||
php-deprecated-in-v1.0.0-test-fail: | ||
test.succeed_without_changes: | ||
- name: | | ||
################################################################################ | ||
# # | ||
# WARNING: BREAKING CHANGES SINCE `v1.0.0` # | ||
# # | ||
################################################################################ | ||
# # | ||
# Prior to `v1.0.0`, this formula provided two methods for managing php; the # | ||
# old method under `php` and the new method under `php.ng`. The old method # | ||
# has now been removed and `php.ng` has been promoted to be `PHP` in its # | ||
# place. # | ||
# # | ||
# If you are not in a position to migrate, please pin your repo to the final # | ||
# release tag before `v1.0.0`, i.e. `v0.37.1`. # | ||
# # | ||
# To migrate from `php.ng`, simply modify your pillar to promote the entire # | ||
# section under `php:ng` so that it is under `php` instead. So with the # | ||
# editor of your choice, highlight the entire section and then unindent one # | ||
# level. Finish by removing the `ng:` line. # | ||
# # | ||
# To migrate from the old `php`, first convert to `php.ng` under `v0.37.0` # | ||
# and then follow the steps laid out in the paragraph directly above. # | ||
# # | ||
################################################################################ | ||
# - failhard: True | ||
n-rodriguez marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-dev: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-gd: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-imagick: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-imap: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-intl: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-json: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-ldap: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-mail: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-mbstring: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-mcrypt: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-memcache: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-memcached: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-mysql: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-mysqlnd: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-oauth: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-pear: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-pgsql: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-readline: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-redis: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-soap: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-sqlite: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
- php.dev | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-sybase: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-xml: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{%- from "php/map.jinja" import php with context %} | ||
|
||
include: | ||
- php.deprecated | ||
- php | ||
|
||
php-zip: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.