-
Notifications
You must be signed in to change notification settings - Fork 2
Feautre/add input fields to searchbar #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
69e2dd7
955fcd1
10d97ab
3ee3fdb
256215a
f5d4a0c
b44663d
c009195
483e55a
8b9d9dd
b946394
6616f39
81cb154
5f3bf71
2d26683
fbae9b5
fa46fb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the DatePickerComponent should be less concerned with the search bar functionality. To keep up/down arrow navigation functionality I think it would be fine to use a capture phase event handler (https://svelte.dev/tutorial/svelte/capturing) in the search bar drop down to intercept up and down arrows before they even reach the text input using I think you could use a similar strategy for detecting focus without touching the DatePickerComponent. Or alternatively just add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I would want to lint the book markdown files. Can we fix the issues without disabling linting of those files completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. but
book/bookdoesn't exist anywhere, so this was unnecessary, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you install mdbook and build the book locally it generates the HTML files there.